Add save reminder to Adv mode and change colors based on how long it has been since a save#1384
Conversation
myk002
left a comment
myk002
left a comment
There was a problem hiding this comment.
please also add a changelog entry
realSquidCoder
changed the title
internal/notify/notifications.lua
Outdated
|
|
||
| -- the order of this list controls the order the notifications will appear in the overlay | ||
| NOTIFICATIONS_BY_IDX = { | ||
| {-- The save reminder should always be at the top, since it's important. |
There was a problem hiding this comment.
Everything here is important : P I'd actually argue that this should go at the bottom because it is more likely than other notifications to be visible for a long time
There was a problem hiding this comment.
my issue with it being at the bottom is that when lots of notifications are active, it gets hidden at the bottom with a scroll needed. putting it at the top and making it configurable means that you make it show up exactly when you want it AND it won't be hidden away
use `:lua reqscript('internal/notify/notifications').save_time_threshold_mins=X` to set the threshold to X mins
|
I need someone to make sure this doesnt hang in adventure mode |
|
@myk002 This mostly looks all good to me however see my comment above on why i wanted to move the save reminder to the top and after we resolve that i dont see anymore need for changes (beyond merge conflicts etc, if any) |
|
I just haven't had time to test. I wanted to look into your previous comments that the dialog was causing hangs |
|
seems reasonable, however i think it was a me issue because its no longer hanging. maybe i had some weird interaction with a branch, idk. still worth a test tho. i posted the line of lua to set the reminder to 1 min for faster testing btw |
2 participants
Closes: DFHack/dfhack#5285
idk why i didnt do this originally
Edit: it turns yellow at 30 mins and red at 60.